fix: honor zero history limits in the FileSession example - #4979
Open
JiangLLM wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in the
FileSessionexample.When a caller asks for zero messages,
get_items(limit=0)returns all saved messages. It should return an empty list.The cause is
items[-limit:]. Whenlimitis zero, Python reads this asitems[0:].The fix returns an empty list for zero. Other limit values work as before. The saved messages stay unchanged.
Test plan
None.The full local test run had 9,577 passes, 56 skips, and 11 failures. All 11 failures occurred because the local sandbox blocked a test server from opening a port. The serial tests did not run.
Full verification is still incomplete.
Issue number
No issue is linked to this PR.
Checks
.agents/skills/code-change-verification/scripts/run.sh./reviewbefore submission.A separate Codex agent reviewed the full diff. The
/reviewcommand was not run.