fix: preserve exact IDs in AdvancedSQLiteSession.delete_branch - #4980
Draft
JiangLLM wants to merge 1 commit into
Draft
fix: preserve exact IDs in AdvancedSQLiteSession.delete_branch#4980JiangLLM wants to merge 1 commit into
JiangLLM wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes incorrect branch deletion in
AdvancedSQLiteSession.Summary
The API treats
"draft"and" draft "as distinct branch IDs. However,delete_branch()removes spaces at both ends of the ID. As a result, a request to delete" draft "can delete"draft"instead.This fix preserves the exact ID after the blank-input check. It also adds tests that verify the requested branch is removed and the other histories remain intact.
Test plan
Issue number
None.
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PRAI tools assisted with the analysis, code, tests, and review. The
/reviewcommand itself has not been run.