-
Notifications
You must be signed in to change notification settings - Fork 292
Enable semantic voice activity detection option #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+110
−57
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 0 additions & 50 deletions
50
src/Generated/Models/Realtime/InternalRealtimeSemanticVadTurnDetectionEagerness.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
// <auto-generated/> | ||
|
||
#nullable disable | ||
|
||
using System; | ||
using System.ComponentModel; | ||
using System.Diagnostics.CodeAnalysis; | ||
using OpenAI; | ||
|
||
namespace OpenAI.Realtime | ||
{ | ||
[Experimental("OPENAI002")] | ||
public readonly partial struct SemanticEagernessLevel : IEquatable<SemanticEagernessLevel> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yay! Extensibile! |
||
{ | ||
private readonly string _value; | ||
private const string LowValue = "low"; | ||
private const string MediumValue = "medium"; | ||
private const string HighValue = "high"; | ||
private const string AutoValue = "auto"; | ||
|
||
public SemanticEagernessLevel(string value) | ||
{ | ||
Argument.AssertNotNull(value, nameof(value)); | ||
|
||
_value = value; | ||
} | ||
|
||
public static SemanticEagernessLevel Low { get; } = new SemanticEagernessLevel(LowValue); | ||
|
||
public static SemanticEagernessLevel Medium { get; } = new SemanticEagernessLevel(MediumValue); | ||
|
||
public static SemanticEagernessLevel High { get; } = new SemanticEagernessLevel(HighValue); | ||
|
||
public static SemanticEagernessLevel Auto { get; } = new SemanticEagernessLevel(AutoValue); | ||
|
||
public static bool operator ==(SemanticEagernessLevel left, SemanticEagernessLevel right) => left.Equals(right); | ||
|
||
public static bool operator !=(SemanticEagernessLevel left, SemanticEagernessLevel right) => !left.Equals(right); | ||
|
||
public static implicit operator SemanticEagernessLevel(string value) => new SemanticEagernessLevel(value); | ||
|
||
[EditorBrowsable(EditorBrowsableState.Never)] | ||
public override bool Equals(object obj) => obj is SemanticEagernessLevel other && Equals(other); | ||
|
||
public bool Equals(SemanticEagernessLevel other) => string.Equals(_value, other._value, StringComparison.InvariantCultureIgnoreCase); | ||
|
||
[EditorBrowsable(EditorBrowsableState.Never)] | ||
public override int GetHashCode() => _value != null ? StringComparer.InvariantCultureIgnoreCase.GetHashCode(_value) : 0; | ||
|
||
public override string ToString() => _value; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can use a visitor to generate these rather than having to maintain stubs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I totally agree with this. We’ve been maintaining separate generator stubs per client, and switching to a visitor would make it much easier to manage these going forward. I’ve created an issue to track this: #550, and we’ll look into addressing it as part of that. Thanks for the suggestion!