Skip to content

Conversation

judyjoseph
Copy link

Update the comments of few SA stats viz. SAI_MACSEC_SA_STAT_IN_PKTS_INVALID, SAI_MACSEC_SA_STAT_IN_PKTS_NOT_USING_SA, SAI_MACSEC_SA_STAT_IN_PKTS_UNUSED_SA, SAI_MACSEC_SA_STAT_IN_PKTS_OK, SAI_MAC to make it clear that these stats are cumulative as other attributes.

@judyjoseph judyjoseph requested a review from kcudnik January 27, 2025 19:16
@judyjoseph judyjoseph force-pushed the update_macsec_attr_comments branch from 33decea to f097169 Compare January 28, 2025 17:06
@tjchadaga
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Feb 2, 2025

WARNING: Word 'InPktsInvalid' is misspelled saimacsec.h 968: * statistics InPktsInvalid.
WARNING: Word 'InPktsOk' is misspelled saimacsec.h 996: * statistics InPktsOk.
Processing sai_8h.xml

@judyjoseph
Copy link
Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 2136 in repo opencomputeproject/SAI

@tjchadaga
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Collaborator

@JaiOCP - please help sign off on this

@kcudnik
Copy link
Collaborator

kcudnik commented Mar 13, 2025

please fix build errors

@tjchadaga
Copy link
Collaborator

WARNING: Word 'InPktsInvalid' is misspelled saimacsec.h 968: * statistics InPktsInvalid. WARNING: Word 'InPktsOk' is misspelled saimacsec.h 996: * statistics InPktsOk. Processing sai_8h.xml

@kcudnik - could you please suggest how to address this? The words are not misspelled

@kcudnik
Copy link
Collaborator

kcudnik commented Mar 15, 2025

Add them to aspell.en

@tjchadaga
Copy link
Collaborator

Add them to aspell.en

@judyjoseph - could you please try this?

@kcudnik
Copy link
Collaborator

kcudnik commented May 30, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants