Skip to content

Next hop group attribute to specify if weights are achieved by repeating members or via the weighting support in the hardware.. #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Next hop group attribute to specify if weights are achieved by repeating members or via the weighting support in the hardware.. #2166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions inc/sainexthopgroup.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,17 @@ typedef enum _sai_next_hop_group_attr_t
*/
SAI_NEXT_HOP_GROUP_ATTR_LABEL,

/**
* @brief Weighted multi path configuration mode.
* false: Nexthop group is programmed with repeated member entries proportional to their weight
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the SAI implementation repeats next hop group member entries, should the SAI_SWITCH_ATTR_AVAILABLE_NEXT_HOP_GROUP_MEMBER_ENTRY attribute be updated to reflect the count of the repeated entries, or should it be based on the number of unique members in the ASIC_DB?

* true: Nexthop group is programmed with switch native configuration
*
* @type bool
* @flags CREATE_AND_SET
* @default false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of "false" will NOT be backward compatible for devices that support Native WCMP.

The name of this attribute must be SAI_NEXT_HOP_GROUP_ATTR_DISABLE_NATIVE_WCMP with default value as False.

*/
SAI_NEXT_HOP_GROUP_ATTR_NATIVE_WCMP,

/**
* @brief End of attributes
*/
Expand Down