SAI LPO attributes #2178
SAI LPO attributes #2178
Conversation
Signed-off-by: pullarao <[email protected]>
pullaraogunda
force-pushed
the
sai_lpo_attributes
branch
from
5d8e6ef to
617a6e0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| * @default empty | ||
| */ | ||
| SAI_PORT_SERDES_ATTR_REACH_MODE, | ||
|
|
There was a problem hiding this comment.
please check if this attribute is a standard one, defined in the spec and can be beneficial for all vendors. If it is vendor-specific please consider using the SAI "custom" infrastructure (#2122)
| * @flags CREATE_AND_SET | ||
| * @default empty | ||
| */ | ||
| SAI_PORT_SERDES_ATTR_RX_ECD_MLSE_STATE, |
There was a problem hiding this comment.
Please also double-check if it is a standard attribute. See my comment above
There was a problem hiding this comment.
@eddyk-nvidia MLSE is a known technique similar to existing channel equalization techniques like DFE, FFE, CTLE. Though here its being introduced in the LPO context, its not a mandatory attribute as per the LPO MSA. Its upto the user if they want to derive the extra BER improved performance that comes with MLSE being enabled(at the cost of extra power). For example, NLC attribute introduced here is also optional and not mandatory but helps to remove the non linearity based on your application specific channel characteristics.
There was a problem hiding this comment.
@eddyk-nvidia All these attributes are optional. Could you please provide your feedback.
|
@eddyk-nvidia, @prgeor - could you please complete the review on this? |
| * @flags CREATE_AND_SET | ||
| * @default empty | ||
| */ | ||
| SAI_PORT_SERDES_ATTR_REACH_MODE, |
There was a problem hiding this comment.
@pullaraogunda can we move this to custom attribute since this is not applicable for all vendors ?
SAI_PORT_SERDES_ATTR_END,
/** Custom range base value */
SAI_PORT_SERDES_ATTR_CUSTOM_RANGE_START = 0x10000000,
/** End of custom range base */
SAI_PORT_SERDES_ATTR_CUSTOM_RANGE_END
SAI port serdes attributes support for Linear Pluggable Optics (LPO)