Skip to content

Conversation

komal-marvell
Copy link
Contributor

@komal-marvell komal-marvell commented Jul 1, 2025

Metadata can be assigned in the Next Hop Table and subsequently matched in ACL entries, providing increased flexibility for policy management.

@kcudnik
Copy link
Collaborator

kcudnik commented Jul 1, 2025

please resolve conflicts and add description

@tjchadaga
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga
Copy link
Collaborator

@ashutosh-agrawal - please help review

@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Jul 11, 2025
inc/saiacl.h Outdated
* @flags CREATE_ONLY
* @default false
*/
SAI_ACL_TABLE_ATTR_FIELD_NEXT_HOP_DST_USER_META = SAI_ACL_TABLE_ATTR_FIELD_START + 0x162,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include DST in the attribute name? I understand that corresponding neighbor attribute also has DST in the attribute name but port, vlan and acl attributes don't. In my opinion, DST in the attribute name is required for FDB and ROUTE objects only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ashutosh-agrawal for the review. Name updated to "SAI_ACL_TABLE_ATTR_FIELD_NEXT_HOP_USER_META"

Copy link
Contributor

@ashutosh-agrawal ashutosh-agrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved with the assumption that attribute name will be changed as discussed in the community meeting.

@tjchadaga
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@komal-marvell
Copy link
Contributor Author

Metadata can be assigned in the Next Hop Table and subsequently matched in ACL entries, providing increased flexibility for policy management.

@komal-marvell
Copy link
Contributor Author

@kcudnik : 1 check is failing.

opencomputeproject.SAIFailing after 3m — Build #20250806.2 failed

##[error]Bash exited with code '100'.
Finishing: Install thrift compiler

Looks like this might be an infrastructure issue (missing or broken repository during apt-get update). Let me know if it's something I should fix on my side.

@rck-innovium
Copy link
Contributor

/azpw run

@tjchadaga
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tjchadaga tjchadaga merged commit 6a2574e into opencomputeproject:master Aug 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed PR is discussed in SAI Meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants