-
Notifications
You must be signed in to change notification settings - Fork 543
Update DWRR scheduler weight range #2188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DWRR scheduler weight range #2188
Conversation
cc621a4
to
f163c86
Compare
@JaiOCP could you please review |
@eddyk-nvidia could you please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the assumption that review comment would be taken care off
inc/saischeduler.h
Outdated
@@ -71,7 +71,7 @@ typedef enum _sai_scheduler_attr_t | |||
/** | |||
* @brief Scheduling algorithm weight | |||
* | |||
* Range [1 - 100]. | |||
* Range [1 - 255]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the comments reflecting the 8 bit value range 0..255, where 0 is invalid value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JaiOCP Updated the range to 0...255 and 0 as invalid weight
Signed-off-by: Kumaresh Perumal <[email protected]>
Signed-off-by: Kumaresh Perumal <[email protected]>
29cce00
to
9ce6019
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@rajkumar38, @ashutosh-agrawal - please help get this reviewed |
@ashutosh-agrawal @itaibaz Could you please review and approve the PR |
I think there was already a suggestion to add a new switch attribute, dwrr weight range, uint8 range, that will reflect the HW capabilities, for example [1..100] or [1..255] and would allow the application to query that |
Thanks @itaibaz Max DWRR weight using switch capability will be added in the later PRs. This PR is a minor change to only update the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Kumaresh!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* Update DWRR weight range Signed-off-by: Kumaresh Perumal <[email protected]>
Current DWRR weight range is from 1-100, increase to 1-255 as some ASIC supports higher value.