Skip to content

Conversation

@rata
Copy link
Member

@rata rata commented Mar 13, 2025

Here is the changelog.

EDIT: brain fart, go version was not changed, got confused.
I'm just seeing that we are changing the min go version from 1.22 to 1.23. It seems to be the first time we do this in a patch release. I guess this can cause issues for distros, just when keeping the runc package up to date. Also, having a quick look it seems kubernetes nor containerd do that (just checked the go.mod on different branches, the go version is always older for older branches).


[1.2.6] - 2025-03-17

Hasta la victoria, siempre.

Fixed

Removed

Changed

  • Use Go 1.23 for official builds, run CI with Go 1.24 and drop Ubuntu 20.04
    from CI. We need to drop Ubuntu 20.04 from CI because Github Actions
    announced it's already deprecated and it will be discontinued soon. ([1.2] Add Go 1.24, drop ubuntu 20.04 #4648)

@rata rata added this to the 1.2.6 milestone Mar 13, 2025
@kolyshkin
Copy link
Contributor

I'm just seeing that we are changing the min go version from 1.22 to 1.23.

Where? https://github.com/opencontainers/runc/blob/release-1.2/go.mod still shows go 1.22 to me.

@rata
Copy link
Member Author

rata commented Mar 13, 2025

@kolyshkin ouch, got confused with the PR, but it's not. Sorry! I'll update this

@kolyshkin
Copy link
Contributor

Perhaps makes sense to add:

Probably does not make sense to mention #4668 as it's internal to the project.

@kolyshkin
Copy link
Contributor

Guess we can fast-track #4678 to be included as well (no need to mention in the changelog though).

Signed-off-by: Rodrigo Campos <[email protected]>
@rata
Copy link
Member Author

rata commented Mar 14, 2025

@kolyshkin Added those to the changelog, rebased on top of the new merged PR and improved the style a little. PTAL :)

Signed-off-by: Rodrigo Campos <[email protected]>
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@cyphar
Copy link
Member

cyphar commented Mar 14, 2025

@kolyshkin I'm on vacation, feel free to do the release yourself. 😸

@rata
Copy link
Member Author

rata commented Mar 17, 2025

@AkihiroSuda @lifubang PTAL

@rata
Copy link
Member Author

rata commented Mar 17, 2025

@kolyshkin if you don't release today, remember to adjust the date. You should be able to push to this branch.

@kolyshkin kolyshkin merged commit b44b3b6 into opencontainers:release-1.2 Mar 17, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants