-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Release 1.2.6 #4674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.2.6 #4674
Conversation
Where? https://github.com/opencontainers/runc/blob/release-1.2/go.mod still shows go 1.22 to me. |
|
@kolyshkin ouch, got confused with the PR, but it's not. Sorry! I'll update this |
|
Perhaps makes sense to add:
Probably does not make sense to mention #4668 as it's internal to the project. |
|
Guess we can fast-track #4678 to be included as well (no need to mention in the changelog though). |
Signed-off-by: Rodrigo Campos <[email protected]>
|
@kolyshkin Added those to the changelog, rebased on top of the new merged PR and improved the style a little. PTAL :) |
Signed-off-by: Rodrigo Campos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
|
@kolyshkin I'm on vacation, feel free to do the release yourself. 😸 |
|
@AkihiroSuda @lifubang PTAL |
|
@kolyshkin if you don't release today, remember to adjust the date. You should be able to push to this branch. |
Here is the changelog.
EDIT: brain fart, go version was not changed, got confused.
I'm just seeing that we are changing the min go version from 1.22 to 1.23. It seems to be the first time we do this in a patch release. I guess this can cause issues for distros, just when keeping the runc package up to date. Also, having a quick look it seems kubernetes nor containerd do that (just checked the go.mod on different branches, the go version is always older for older branches).[1.2.6] - 2025-03-17
Fixed
O_CLOEXECwithCloseExecFromfailed ([1.2] libcontainer: Prevent startup hang when CloseExecFrom errors #4647).runcnow properly handles joining time namespaces (such as withrunc exec). Previously we would attempt to set the time offsets when joining,which would fail. (Can't exec into a container with private time namespace #4635, [1.2] libct: don't send config to nsexec when joining an existing timens #4649)
EINTRretries correctly for socket-related directgolang.org/x/sys/unixsystem calls. ([1.2] Retry direct unix package calls if observing EINTR #4650)F_SEAL_FUTURE_WRITEwhen sealing the runc binary, as itturns out this had some unfortunate bugs in older kernel versions and was
never necessary in the first place. ([1.2] exeseal: do not use F_SEAL_FUTURE_WRITE #4651, runc gets stuck #4640)
Removed
Fexecvehelper fromlibcontainer/system. Runc 1.2.1 removedrunc-dmz, but we forgot to remove this helper added only for that. ([1.2] libct/system: rm Fexecve #4646)
Changed
from CI. We need to drop Ubuntu 20.04 from CI because Github Actions
announced it's already deprecated and it will be discontinued soon. ([1.2] Add Go 1.24, drop ubuntu 20.04 #4648)