Skip to content

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jul 16, 2025

No description provided.

@kolyshkin
Copy link
Contributor Author

CI failure is being fixed by #4807

@kolyshkin kolyshkin marked this pull request as ready for review July 16, 2025 22:46
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder why the linter is checking files out of this PR. Do you happen to know?

@kolyshkin kolyshkin force-pushed the golangci-lint-22 branch 2 times, most recently from 31a6d6f to 513b10f Compare July 24, 2025 18:49
@kolyshkin kolyshkin changed the title ci: bump golangci-lint to v2.2.x ci: bump golangci-lint to v2.3.x Jul 24, 2025
@kolyshkin
Copy link
Contributor Author

I wonder why the linter is checking files out of this PR. Do you happen to know?

The "lint" job checks everything; it's only the "lint-extra" step (at the end of the "lint" job) is supposed to only check the changes introduced by the PR, using some extra (more strict) linters configured in .golangci-extra.yml.

Also, I've seen that there are some linting problems caused by golangci-lint cache. Not quite sure what's the ultimate reason but fingers crossed it is being fixed; keeping my eye on it.

@lifubang lifubang enabled auto-merge July 25, 2025 04:38
@lifubang lifubang merged commit b33b527 into opencontainers:main Jul 25, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants