Small changes to get it working on latest version of python and packages #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @EmanueleCannizzaro for your contribution! Could you please correct the description of your pull request, and tell us the main differences of this changeset with #1181, #1161 and #1168? 🙂 Thanks! |
|
|
||
|
|
||
| def contains_nan(vector): | ||
| print(vector) |
There was a problem hiding this comment.
Could you please remove this print statement?
| import traceback | ||
|
|
||
| import numpy | ||
| import pandas as pd |
There was a problem hiding this comment.
If it is useful to test pandas here, I suggest we move this as an actual test, and that we require pandas optionally in case we want to run that specific test.
| if period is not None and not isinstance(period, Period): | ||
| period = periods.period(period) | ||
| ##period = periods.period(period) | ||
| period = Period(period) |
There was a problem hiding this comment.
This is a breaking change (the badly named periods.period function is actually a builder function.
| from nptyping import types, NDArray as Array | ||
| # Modified by Emanuele Cannizzaro on 03/06/2023 | ||
| #from typing import types, NDArray as Array | ||
| import types |
There was a problem hiding this comment.
Thanks for this! We should completely get rid of nptyping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to OpenFisca! Remove this line, as well as any other in the following that don't fit your contribution :)
Breaking changes
New features
some_function()Deprecations
some_function.Technical changes
private_function.