8367975: [CRaC] Pattern in CRaCCheckpointTo

[rvansa]

Add support for pattern in CRaCCheckpointTo VM option.

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8367975: [CRaC] Pattern in CRaCCheckpointTo (Enhancement - P4)

Reviewers

• Timofei Pushkin (@TimPushkin - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/264/head:pull/264
$ git checkout pull/264

Update a local copy of the PR:
$ git checkout pull/264
$ git pull https://git.openjdk.org/crac.git pull/264/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 264

View PR using the GUI difftool:
$ git pr show -t 264

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/264.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into crac will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rvansa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367975: [CRaC] Pattern in CRaCCheckpointTo

Reviewed-by: tpushkin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the crac branch:

• 5abb5da: 8368570: [CRaC] Improve JdwpTransportTest

Please see this link for an up-to-date comparison between the source branch of this pull request and the crac branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the crac branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 05: Full - Incremental (fea2f6d8)
• 04: Full - Incremental (d5f1cc35)
• 03: Full - Incremental (c4e81fd2)
• 02: Full - Incremental (b02f242e)
• 01: Full - Incremental (f6be8b42)
• 00: Full (7c23d813)

[TimPushkin]

The patterns should be documented in java.md and maybe mentioned in globals.hpp.

Also since the patterns are handled in shared code it would make sense to have OS pattern too.

[rvansa]

@TimPushkin Thank you for the review, I've addressed all your comments, I think.

I've considered adding %o for OS name matching os.name property, but turns out this is non-trivial outside POSIX systems where struct utsname.sysname (from uname) is used: on Mac's this is hardcoded, on Windows there's a complex switch and this is not exposed in VM code through some os::name() adapter. So I won't go the extra miles to get the value; I don't think that in practice this will be used on non-Linux systems anyway.

[rvansa]

Looks like when I've created the PR from a branch in this repository the GHA with tests is not executed. Pushed the code to my repo, too, tests running here: https://github.com/rvansa/crac/actions/runs/18130706409

[TimPushkin]

@rvansa There are still build and test failures in your repo

[rvansa]

@TimPushkin I hope I have addressed these, and a green build in CI is here: https://github.com/rvansa/crac/actions/runs/18275647535

[TimPushkin]

LGTM

[TimPushkin]

Not critical, but we could also try MAX_PATH defined in Windows before falling back to a hard-coded value

[rvansa]

/integrate

[openjdk]

Going to push as commit b47bafb.
Since your change was applied there has been 1 commit pushed to the crac branch:

• 5abb5da: 8368570: [CRaC] Improve JdwpTransportTest

Your commit was automatically rebased without conflicts.

[openjdk]

@rvansa Pushed as commit b47bafb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.