Skip to content

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Jun 17, 2025

Linux core files contain absolute paths to all libraries that were loaded in memory at the time the core dump was taken. If the file paths do not match the ones present on the machine where SA runs, loading the core file requires setting SA_ALTROOT and copying additional binaries (ld-linux, possibly others).

We can do better than that; we know the path to the executable file on the SA machine, and the core dump contains the path to the executable file on the original machine. Based on the two locations, we can rewrite the paths in the core dump to corresponding paths on the SA machine.

The code added in this PR reads all file paths in the NT_FILE section, and tries to match them to the executable file name passed on the command line with the --exe parameter. Once a matching path is found, the common suffix is stripped, and the differing prefixes are used to remap the paths to other JDK files.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355047: SA fails to discover JDK libraries for Linux core files (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25861/head:pull/25861
$ git checkout pull/25861

Update a local copy of the PR:
$ git checkout pull/25861
$ git pull https://git.openjdk.org/jdk.git pull/25861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25861

View PR using the GUI difftool:
$ git pr show -t 25861

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25861.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2025

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8355047 8355047: SA fails to discover JDK libraries for Linux core files Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@djelinski The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2025

@djelinski This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant