8360048: NMT crash in gtest/NMTGtests.java: fatal error: NMT corruption: Block at 0x0000017748307120: header canary broken

[afshin-zafari]

The canary header test failed since there were concurrent remove and free() from the tree. The remove operations are synch'ed with corresponding NMT lock. The ReserveMemory::reserve() uses the same lock internally and is not included in the locked code block.

Tests: tier5 {macosx-aarch64, linux-x64, windows-x64} x {debug, release}

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8360048: NMT crash in gtest/NMTGtests.java: fatal error: NMT corruption: Block at 0x0000017748307120: header canary broken (Bug - P2)

Reviewers

• Johan Sjölen (@jdksjolen - Reviewer)
• Gerard Ziemski (@gerard-ziemski - Reviewer) Review applies to 51600cdd

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25950/head:pull/25950
$ git checkout pull/25950

Update a local copy of the PR:
$ git checkout pull/25950
$ git pull https://git.openjdk.org/jdk.git pull/25950/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25950

View PR using the GUI difftool:
$ git pr show -t 25950

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25950.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360048: NMT crash in gtest/NMTGtests.java: fatal error: NMT corruption: Block at 0x0000017748307120: header canary broken

Reviewed-by: jsjolen, gziemski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• a26a6f3: 8364649: G1: Move collection set related full gc reset code into abandon_collection_set() method
• 47017e3: 8364760: G1: Remove obsolete code in G1MergeCardSetClosure
• bcca5ce: 8364642: G1: Remove parameter in G1CollectedHeap::abandon_collection_set()
• ... and 21 more: https://git.openjdk.org/jdk/compare/72d1066ae385ce511a70e762ed68afaa72e96ec4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (f6b00951)
• 01: Full - Incremental (51600cdd)
• 00: Full (461a00ed)

[jdksjolen]

It would be good if we could remove the dependency on the global instance in the source code and create new VMT's for each test. That would make the tests less brittle.

[gerard-ziemski]

I think I asked about this before - can we do remove_all in the constructor to avoid this 2 line repeating pattern?

Otherwise looks good, can you please check the GHA test failures on Windows?

[jdksjolen]

I don't think that's the right way to go. I think it's better if we can avoid using the global instance, and not change the code of the VMT in order to appease the tests.

[gerard-ziemski]

Sure, I suggested the easiest fix I could think of, but doing it this way is even better!

[jdksjolen]

Nice!

[gerard-ziemski]

LGTM

[bridgekeeper]

@afshin-zafari This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[afshin-zafari]

keep it open, bot!

[openjdk]

@afshin-zafari this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout _8360048_corrupted_canary_header
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[afshin-zafari]

Thanks for your reviews @jdksjolen and @gerard-ziemski.
/integrate

[openjdk]

@afshin-zafari This pull request has not yet been marked as ready for integration.

[jdksjolen]

Re-approved

[afshin-zafari]

Thank you @jdksjolen.
/integrate

[openjdk]

Going to push as commit 1b3e231.
Since your change was applied there have been 24 commits pushed to the master branch:

• a26a6f3: 8364649: G1: Move collection set related full gc reset code into abandon_collection_set() method
• 47017e3: 8364760: G1: Remove obsolete code in G1MergeCardSetClosure
• bcca5ce: 8364642: G1: Remove parameter in G1CollectedHeap::abandon_collection_set()
• ... and 21 more: https://git.openjdk.org/jdk/compare/72d1066ae385ce511a70e762ed68afaa72e96ec4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@afshin-zafari Pushed as commit 1b3e231.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.