8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError

[sendaoYan]

Hi all,

This pull request contains a backport of commit cbb3d23e from the openjdk/jdk repository to jdk25.

Test-fix only to improves test performance and stability. Change has been verified locally, no risk.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError (Bug - P4)

Reviewers

• Richard Reingruber (@reinrich - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26343/head:pull/26343
$ git checkout pull/26343

Update a local copy of the PR:
$ git checkout pull/26343
$ git pull https://git.openjdk.org/jdk.git pull/26343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26343

View PR using the GUI difftool:
$ git pr show -t 26343

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26343.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361827: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java throws OutOfMemoryError

Reviewed-by: rrich, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the jdk25 branch:

• 5cc7a31: 8361869: Tests which call ThreadController should mark as /native
• f1f6452: 8358004: Delete applications/scimark/Scimark.java test
• 331adac: 8361639: JFR: Incorrect top frame for I/O events
• ... and 9 more: https://git.openjdk.org/jdk/compare/0e6bf0055057fae844748a300551549553f59f03...jdk25

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk25 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6671e841)

[lmesnik]

The Systen.gc() might not trigger full GC.

While not tjust o restrict heap for this test? 256M should be enough.

[reinrich]

The Systen.gc() might not trigger full GC.

Indeed. Might be better to use the Whitebox or start a dedicated VM.

While not tjust o restrict heap for this test? 256M should be enough.

This would not help. The tests accumulate heap dumps until OOM. See reproducer.

[reinrich]

It might not be the perfect solution but it surely reduces the noise in our testing.
So let's have this improvement in jdk25.
In jdk26 we can change the test to use WhiteBox::fullGC. What do you think?

[reinrich]

I've created a draft pr: #26363

[lmesnik]

That's fine.

[lmesnik]

That's fine.

[sendaoYan]

Thanks @lmesnik @reinrich

/integrate

[openjdk]

Going to push as commit e599ee4.
Since your change was applied there have been 14 commits pushed to the jdk25 branch:

• 3a8e9df: 8362565: ProblemList jdk/jfr/event/io/TestIOTopFrame.java
• 347084b: 8360288: Shenandoah crash at size_given_klass in op_degenerated
• 5cc7a31: 8361869: Tests which call ThreadController should mark as /native
• ... and 11 more: https://git.openjdk.org/jdk/compare/0e6bf0055057fae844748a300551549553f59f03...jdk25

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit e599ee4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.