Skip to content

8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts #26388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts #26388

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7853b2a
8362602: Add test.timeout.factor to CompileFactory to avoid test time…
dbriemann Jul 16, 2025
87fdf24
update copyright header
dbriemann Jul 21, 2025
074bbca
make timeout factor scale linearly
dbriemann Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/hotspot/jtreg/compiler/lib/compile_framework/Compile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
*/
class Compile {
private static final int COMPILE_TIMEOUT = 60;
private static final float timeoutFactor = Float.parseFloat(System.getProperty("test.timeout.factor", "1.0"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the copyright year.


private static final String JAVA_PATH = JDKToolFinder.getJDKTool("java");
private static final String JAVAC_PATH = JDKToolFinder.getJDKTool("javac");
Expand Down Expand Up @@ -182,7 +183,8 @@ private static void executeCompileCommand(List<String> command) {
int exitCode;
try {
Process process = builder.start();
boolean exited = process.waitFor(COMPILE_TIMEOUT, TimeUnit.SECONDS);
long timeout = COMPILE_TIMEOUT * (long)Math.pow(2, timeoutFactor-1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for scaling the timeout exponentially instead of linearly, as jtreg does it and most users would expect?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that I saw this documented somewhere but I cannot find it anymore and in other places it is used linearly, like you say.

I adapted it.

boolean exited = process.waitFor(timeout, TimeUnit.SECONDS);
if (!exited) {
process.destroyForcibly();
System.out.println("Timeout: compile command: " + String.join(" ", command));
Expand Down