-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8362882: Update SubmissionPublisher() specification to reflect use of ForkJoinPool.asyncCommonPool() #26426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/csr |
👋 Welcome back alanb! A progress list of the required criteria for merging this PR into |
@AlanBateman This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request. @AlanBateman this pull request must refer to an issue in JBS to be able to link it to a CSR request. To refer this pull request to an issue in JBS, please update the title of this pull request to just the issue ID. |
@AlanBateman The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/touch |
@AlanBateman The pull request is being re-evaluated and the inactivity timeout has been reset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK to me and matches the current implementation of this constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry to have missed this before.
/integrate |
Going to push as commit f79bd54.
Your commit was automatically rebased without conflicts. |
@AlanBateman Pushed as commit f79bd54. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport :jdk25 |
@AlanBateman the backport was successfully created on the branch backport-AlanBateman-f79bd54b-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:
|
The changes in JDK-8319447 to improve the performance of delayed task handling updated CompletableFuture and SubmissionPublisher to use the ForkJoinPool commonPool in all cases. These APIs previously created a Thread for each task when parallelism was less than 2. We missed the update to SubmissionPublisher's no-arg constructor in that update.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26426/head:pull/26426
$ git checkout pull/26426
Update a local copy of the PR:
$ git checkout pull/26426
$ git pull https://git.openjdk.org/jdk.git pull/26426/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26426
View PR using the GUI difftool:
$ git pr show -t 26426
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26426.diff
Using Webrev
Link to Webrev Comment