Skip to content

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jul 22, 2025

The changes in JDK-8319447 to improve the performance of delayed task handling updated CompletableFuture and SubmissionPublisher to use the ForkJoinPool commonPool in all cases. These APIs previously created a Thread for each task when parallelism was less than 2. We missed the update to SubmissionPublisher's no-arg constructor in that update.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8363552 to be approved

Issues

  • JDK-8362882: Update SubmissionPublisher() specification to reflect use of ForkJoinPool.asyncCommonPool() (Bug - P3)
  • JDK-8363552: Update SubmissionPublisher() specification to reflect use of ForkJoinPool.asyncCommonPool() (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26426/head:pull/26426
$ git checkout pull/26426

Update a local copy of the PR:
$ git checkout pull/26426
$ git pull https://git.openjdk.org/jdk.git pull/26426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26426

View PR using the GUI difftool:
$ git pr show -t 26426

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26426.diff

Using Webrev

Link to Webrev Comment

@AlanBateman
Copy link
Contributor Author

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2025

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362882: Update SubmissionPublisher() specification to reflect use of ForkJoinPool.asyncCommonPool()

Reviewed-by: jpai, dl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jul 22, 2025
@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@AlanBateman this pull request must refer to an issue in JBS to be able to link it to a CSR request. To refer this pull request to an issue in JBS, please update the title of this pull request to just the issue ID.

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@AlanBateman AlanBateman marked this pull request as ready for review July 23, 2025 09:59
@AlanBateman
Copy link
Contributor Author

/touch

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@AlanBateman The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2025

Webrevs

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK to me and matches the current implementation of this constructor.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Jul 24, 2025
Copy link
Contributor

@DougLea DougLea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry to have missed this before.

@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2025

Going to push as commit f79bd54.
Since your change was applied there have been 35 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2025
@openjdk openjdk bot closed this Jul 25, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2025
@openjdk
Copy link

openjdk bot commented Jul 25, 2025

@AlanBateman Pushed as commit f79bd54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlanBateman
Copy link
Contributor Author

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jul 25, 2025

@AlanBateman the backport was successfully created on the branch backport-AlanBateman-f79bd54b-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f79bd54b from the openjdk/jdk repository.

The commit being backported was authored by Alan Bateman on 25 Jul 2025 and was reviewed by Jaikiran Pai and Doug Lea.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-AlanBateman-f79bd54b-jdk25:backport-AlanBateman-f79bd54b-jdk25
$ git checkout backport-AlanBateman-f79bd54b-jdk25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-AlanBateman-f79bd54b-jdk25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants