8361897: gc/z/TestUncommit.java fails with Uncommitted too slow

[xmas92]

This proposed change loosens the the threshold for flagging slow un-committing as an error in TestUncommit.java. Rather than requiring the un-committing be completed within 3 ZUncommitDelay, allow up to 5 ZUncommitDelay to accommodate the test being executed in environments where external factors affect whether un-committing is run as expected.

In the observed intermittent failures, what can be seen is that the un-committer thread wakes up a significant time after the expected timeout has expired. And because we expect multiple timeouts, the accumulated extra time waiting can push the actual delay just past 3 ZUncommitDelay. Using a factor of 5 instead should remove all but the most extreme intermittent occurrences and still capture if the un-commit logic breaks completely.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361897: gc/z/TestUncommit.java fails with Uncommitted too slow (Bug - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Joel Sikström (@jsikstro - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26536/head:pull/26536
$ git checkout pull/26536

Update a local copy of the PR:
$ git checkout pull/26536
$ git pull https://git.openjdk.org/jdk.git pull/26536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26536

View PR using the GUI difftool:
$ git pr show -t 26536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26536.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361897: gc/z/TestUncommit.java fails with Uncommitted too slow

Reviewed-by: stefank, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• c851735: 8364115: Sort share/services includes
• 317dacc: 8364159: Shenandoah assertions after JDK-8361712
• a6fb87d: 8364042: UnsafeMemoryAccess will not work with AOT cached code stubs
• ... and 13 more: https://git.openjdk.org/jdk/compare/965b68107ffe1c1c988d4faf6d6742629407451b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (315153c8)

[jsikstro]

Looks good.

[xmas92]

Thanks for the reviews
/integrate

[openjdk]

Going to push as commit 3f21c8b.
Since your change was applied there have been 28 commits pushed to the master branch:

• ddb6483: 8364409: [BACKOUT] Consolidate Identity of self-inverse operations
• 8ed214f: 8364090: Dump JFR recording on CrashOnOutOfMemoryError
• b9f7cae: 8364282: ZGC: Improve ZPageAllocation JFR event sending
• ... and 25 more: https://git.openjdk.org/jdk/compare/965b68107ffe1c1c988d4faf6d6742629407451b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@xmas92 Pushed as commit 3f21c8b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.