Skip to content

8364317: Explicitly document some assumptions of StringUTF16 #26541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liach wants to merge 2 commits into from
Closed

8364317: Explicitly document some assumptions of StringUTF16 #26541

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
933557e
Miscellaneous docs and checks for UTF16
liach Jul 28, 2025
1b052e9
Add paragraph for endianness and layout
liach Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/java.base/share/classes/java/lang/StringUTF16.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@

import static java.lang.String.UTF16;

/// UTF16 String operations.
///
/// All indices and sizes for byte arrays carrying UTF16 data are in number of
/// chars instead of number of bytes.
Comment thread
liach marked this conversation as resolved.
final class StringUTF16 {

// Return a new byte array for a UTF16-coded string for len chars
Expand Down Expand Up @@ -1635,6 +1639,9 @@ public static int lastIndexOfLatin1(byte[] src, int srcCount,
private static final int HI_BYTE_SHIFT;
private static final int LO_BYTE_SHIFT;
static {
// Assumptions for StringUTF16 operations. Present in `LibraryCallKit::inline_string_char_access` too.
assert Unsafe.ARRAY_CHAR_BASE_OFFSET == Unsafe.ARRAY_BYTE_BASE_OFFSET : "sanity: byte[] and char[] bases agree";
assert Unsafe.ARRAY_CHAR_INDEX_SCALE == Unsafe.ARRAY_BYTE_INDEX_SCALE * 2 : "sanity: byte[] and char[] scales agree";
if (Unsafe.getUnsafe().isBigEndian()) {
HI_BYTE_SHIFT = 8;
LO_BYTE_SHIFT = 0;
Expand Down