8361387 : Test bug4655513.java fails intermittently on Windows platform.

[anass-baya]

This test was recently automated and is failing intermittently in the CI due to timing issues.
This enhancement aims to stabilize the test and also adds the missing null pointer check.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8361387

Warning

 ⚠️ Found trailing period in issue title for 8361387: Test bug4655513.java fails intermittently on Windows platform.

Issue

• JDK-8361387: Test bug4655513.java fails intermittently on Windows platform (Bug - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26824/head:pull/26824
$ git checkout pull/26824

Update a local copy of the PR:
$ git checkout pull/26824
$ git pull https://git.openjdk.org/jdk.git pull/26824/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26824

View PR using the GUI difftool:
$ git pr show -t 26824

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26824.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abaya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@anass-baya The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (79be7f65)
• 01: Full - Incremental (6e9d08c5)
• 00: Full (07962265)

[prsadhuk]

mousePress parameter should be InputEvent.BUTTON1_DOWN_MASK instead which is usually the norm? mouseRelease is called correctly..
Also, I dont think we usually use delay between drag...guess once drag is complete, we can call waitForIdle and delay..

[anass-baya]

Hello @prsadhuk,
Thank you for your review.
its done

[anass-baya]

Hello @prsadhuk,
We need to add at least waitForIdle() before releasing the mouse button. Otherwise, the test will start failing again.
KR,

[prsadhuk]

OK..Can you please run the test with repeat count of atleast 50 on all platforms and share the result in JBS?

[anass-baya]

Hello @prsadhuk,
Linux is not stable with that one, while it is stable with my first proposed enhancement. Do you agree with rolling back to it?

[prsadhuk]

In the mainline or in other update releases?
I dont see this test fail in mainline except once due to NPE while disposing..
If using slight delay in between mouseMove works well in all trains for multiple iterations then you can add that I presume..

[TejeshR13]

import java.awt.event.MouseEvent; can be removed.

[TejeshR13]

How are you concluding this as timing issue ? Since this issue is intermittent.

[DamonGuy]

I agree. I tested with and without and I haven't seen it occur yet but I can run larger amounts of reruns. I'm not 100% sold that this will fix the intermittent issue but I don't see an issue with the update.