-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8286865: vmTestbase/vm/mlvm/meth/stress/jni/nativeAndMH/Test.java fails with Out of space in CodeCache #26840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ls with Out of space in CodeCache
👋 Welcome back rsunderbabu! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@rsunderbabu The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Test.class, | ||
"calledFromNative", | ||
MT_calledFromNative); | ||
} catch(Exception ex) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} catch(Exception ex) { | |
} catch (Exception ex) { |
-Xcomp is a useful stress flag, and this test is meant to stress MHs, not the code cache, so can we increase the code cache size enough to let it pass with -Xcomp? |
The number of iterations are proportional to number of CPUs. so we cannot predict the required cache size. |
MethodHandle invocations with Xcomp are filling up CodeCache quickly in the test, especially in machines with high number of processors.
It is possible to measure code cache consumption per invocation, estimate overall consumption and bail out before CodeCache runs out of memory.
But it is much simpler to exclude the test for Xcomp flag.
Additional Change: MethodHandles.lookup was done unnecessarily invoked for all iterations. Replaced it with single invocation.
PS: This issue is not seen in JDK 20 and above, possibly due to JDK-8290025, but the exclusion guards against vagaries of CodeCache management.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26840/head:pull/26840
$ git checkout pull/26840
Update a local copy of the PR:
$ git checkout pull/26840
$ git pull https://git.openjdk.org/jdk.git pull/26840/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26840
View PR using the GUI difftool:
$ git pr show -t 26840
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26840.diff
Using Webrev
Link to Webrev Comment