Skip to content

8364733: HttpClient: sendAsync throws unspecified exceptions #26876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vy
Copy link
Contributor

@vy vy commented Aug 21, 2025

Ensure that HttpClient::sendAsync transforms exceptions thrown by request publishers into IOExceptions, as required by the specification.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8364733: HttpClient: sendAsync throws unspecified exceptions (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26876/head:pull/26876
$ git checkout pull/26876

Update a local copy of the PR:
$ git checkout pull/26876
$ git pull https://git.openjdk.org/jdk.git pull/26876/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26876

View PR using the GUI difftool:
$ git pr show -t 26876

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26876.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2025

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 21, 2025

@vy The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Copy link
Member

@liach liach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add new throws Exception declarations if the existing code does not need it.

Copy link
Contributor Author

@vy vy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to add new throws Exception declarations if the existing code does not need it.

@liach, I've did some cleaning in 89dba9a. Let me know if you were concerned about more places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants