-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8364733: HttpClient: sendAsync throws unspecified exceptions #26876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to add new throws Exception
declarations if the existing code does not need it.
src/java.net.http/share/classes/jdk/internal/net/http/PullPublisher.java
Outdated
Show resolved
Hide resolved
src/java.net.http/share/classes/jdk/internal/net/http/PullPublisher.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that
HttpClient::sendAsync
transforms exceptions thrown by request publishers intoIOException
s, as required by the specification.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26876/head:pull/26876
$ git checkout pull/26876
Update a local copy of the PR:
$ git checkout pull/26876
$ git pull https://git.openjdk.org/jdk.git pull/26876/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26876
View PR using the GUI difftool:
$ git pr show -t 26876
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26876.diff