Skip to content

Conversation

sarannat
Copy link
Contributor

@sarannat sarannat commented Aug 22, 2025

Issue

The code that prints node properties and live range properties is very verbose and repetitive and could be simplified by applying a refactoring suggested here.

Fix

Implemented the suggested refactoring.

##Testing
Github Actions, Tier 1-3


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349835: C2: simplify IGV property printing (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26902/head:pull/26902
$ git checkout pull/26902

Update a local copy of the PR:
$ git checkout pull/26902
$ git pull https://git.openjdk.org/jdk.git pull/26902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26902

View PR using the GUI difftool:
$ git pr show -t 26902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26902.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2025

👋 Welcome back snatarajan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8349835: C2: simplify IGV property printing 8349835: C2: simplify IGV property printing Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

@sarannat The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant