Skip to content

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Aug 22, 2025

Some text describing the Beans.instantiate lookup process existed only on the method that used the now removed AppletInitializer.
Since there are two other Beans.instantiate methods, we need to move that text to the remaining methods.

Note that one of the methods is also deprecated for removal, so it seems prudent to add it to both so that when the next to be removed method is gone, this problem doesn't recur.

This is a doc. only change. The CSR is ready for review.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8366018 to be approved

Issues

  • JDK-8366002: Beans.instantiate needs to describe the lookup procedure (Bug - P3)
  • JDK-8366018: Beans.instantiate needs to describe the lookup procedure (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26905/head:pull/26905
$ git checkout pull/26905

Update a local copy of the PR:
$ git checkout pull/26905
$ git pull https://git.openjdk.org/jdk.git pull/26905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26905

View PR using the GUI difftool:
$ git pr show -t 26905

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26905.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8366002 8366002: Specification Update Needed: Beans.instantiate Serialized Object Loading Behavior Aug 22, 2025
@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Aug 22, 2025
@openjdk
Copy link

openjdk bot commented Aug 22, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client [email protected] rfr Pull request is ready for review labels Aug 22, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2025

Webrevs

@prrace prrace changed the title 8366002: Specification Update Needed: Beans.instantiate Serialized Object Loading Behavior 8366002: Beans.instantiate needs to describe the lookup procedure Aug 22, 2025
@mrserb
Copy link
Member

mrserb commented Aug 22, 2025

Do we have any tests that verify it actually works as described in the updated specification?

@prrace
Copy link
Contributor Author

prrace commented Aug 22, 2025

Do we have any tests that verify it actually works as described in the updated specification?

If you didn't see any, there probably aren't.
Well I guess there may be JCK ones, since this came from JCK. But that's out of scope here. I'm just restoring doc.

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you just restoring the relevant portions of the existing javadoc for a removed method. Marking up can be postponed to a later time, if at all.

* This name should be a dot-separated name such as "a.b.c".
* <p>
* The given name can indicate either a serialized object or a class.
* We first try to treat the beanName as a serialized object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* We first try to treat the beanName as a serialized object
* We first try to treat the {@code beanName} as a serialized object

Should this be marked up as it refers the parameter name? Also, in other instances.

* given beanName to a resource pathname and add a trailing ".ser" suffix.
* We then try to load a serialized object from that resource.
* <p>
* For example, given a beanName of "x.y", Beans.instantiate would first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* For example, given a beanName of "x.y", Beans.instantiate would first
* For example, given a beanName of "x.y", {@code Beans.instantiate} would first

Method names should be marked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants