-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8366002: Beans.instantiate needs to describe the lookup procedure #26905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back prr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Do we have any tests that verify it actually works as described in the updated specification? |
If you didn't see any, there probably aren't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you just restoring the relevant portions of the existing javadoc for a removed method. Marking up can be postponed to a later time, if at all.
* This name should be a dot-separated name such as "a.b.c". | ||
* <p> | ||
* The given name can indicate either a serialized object or a class. | ||
* We first try to treat the beanName as a serialized object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* We first try to treat the beanName as a serialized object | |
* We first try to treat the {@code beanName} as a serialized object |
Should this be marked up as it refers the parameter name? Also, in other instances.
* given beanName to a resource pathname and add a trailing ".ser" suffix. | ||
* We then try to load a serialized object from that resource. | ||
* <p> | ||
* For example, given a beanName of "x.y", Beans.instantiate would first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* For example, given a beanName of "x.y", Beans.instantiate would first | |
* For example, given a beanName of "x.y", {@code Beans.instantiate} would first |
Method names should be marked up.
Some text describing the Beans.instantiate lookup process existed only on the method that used the now removed AppletInitializer.
Since there are two other Beans.instantiate methods, we need to move that text to the remaining methods.
Note that one of the methods is also deprecated for removal, so it seems prudent to add it to both so that when the next to be removed method is gone, this problem doesn't recur.
This is a doc. only change. The CSR is ready for review.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26905/head:pull/26905
$ git checkout pull/26905
Update a local copy of the PR:
$ git checkout pull/26905
$ git pull https://git.openjdk.org/jdk.git pull/26905/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26905
View PR using the GUI difftool:
$ git pr show -t 26905
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26905.diff
Using Webrev
Link to Webrev Comment