-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8366225: Linux Alpine (fast)debug build fails after JDK-8365909 #26956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@MBaesken, could you please verify this PR on Alpine Linux? |
👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into |
@mhaessig This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/label add hotspot-compiler |
@mhaessig |
@mhaessig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the Linux Alpine fastdebug build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
FTR: I think this is trivial. |
Thank you for your reviews, @MBaesken and @TobiHartmann! /integrate |
Going to push as commit b43c2c6.
Your commit was automatically rebased without conflicts. |
The integration of #26882 broke debug builds on Alpine Linux (and probably other distributions using musl libc), because the typedef
sigevent_t
does not exist in musl libc. This PR fixes this by usingstruct sigevent
as the type.Testing:
make test TEST=compiler/arguments/TestCompileTaskTimeout.java
in Alpine Linux docker containerProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26956/head:pull/26956
$ git checkout pull/26956
Update a local copy of the PR:
$ git checkout pull/26956
$ git pull https://git.openjdk.org/jdk.git pull/26956/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26956
View PR using the GUI difftool:
$ git pr show -t 26956
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26956.diff
Using Webrev
Link to Webrev Comment