Skip to content

Conversation

mhaessig
Copy link
Contributor

@mhaessig mhaessig commented Aug 27, 2025

The integration of #26882 broke debug builds on Alpine Linux (and probably other distributions using musl libc), because the typedef sigevent_tdoes not exist in musl libc. This PR fixes this by using struct sigevent as the type.

Testing:

  • Github Actions
  • tier1,tier2 Linux aarch64 and x64 fastdebug
  • make test TEST=compiler/arguments/TestCompileTaskTimeout.java in Alpine Linux docker container
  • tier1,tier2 on Alpine Linux fastdebug

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366225: Linux Alpine (fast)debug build fails after JDK-8365909 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26956/head:pull/26956
$ git checkout pull/26956

Update a local copy of the PR:
$ git checkout pull/26956
$ git pull https://git.openjdk.org/jdk.git pull/26956/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26956

View PR using the GUI difftool:
$ git pr show -t 26956

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26956.diff

Using Webrev

Link to Webrev Comment

@mhaessig
Copy link
Contributor Author

@MBaesken, could you please verify this PR on Alpine Linux?

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2025

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366225: Linux Alpine (fast)debug build fails after JDK-8365909

Reviewed-by: mbaesken, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

@mhaessig The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime [email protected] rfr Pull request is ready for review labels Aug 27, 2025
@mhaessig
Copy link
Contributor Author

/label add hotspot-compiler
/label remove hotspot-runtime

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

@mhaessig
The hotspot-compiler label was successfully added.

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

@mhaessig
The hotspot-runtime label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Aug 27, 2025

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the Linux Alpine fastdebug build.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 27, 2025
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@TobiHartmann
Copy link
Member

FTR: I think this is trivial.

@mhaessig
Copy link
Contributor Author

Thank you for your reviews, @MBaesken and @TobiHartmann!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 27, 2025

Going to push as commit b43c2c6.
Since your change was applied there have been 7 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 27, 2025
@openjdk openjdk bot closed this Aug 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 27, 2025
@openjdk
Copy link

openjdk bot commented Aug 27, 2025

@mhaessig Pushed as commit b43c2c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants