8366476: Test gc/z/TestSmallHeap.java fails OOM with many NUMA nodes

[sendaoYan]

Hi all,

The PR JDK-8359683 added NUMA-Aware Relocation for ZGC, it's optimized for the majority of NUMA workloads, but the cost is requiring more headroom in terms of heap memory. This PR add extra JVM option "-XX:-UseNUMA" to make this test run normally.

Test-fix only, change has been verified locally, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366476: Test gc/z/TestSmallHeap.java fails OOM with many NUMA nodes (Bug - P4)

Reviewers

• Joel Sikström (@jsikstro - Committer)
• Axel Boldt-Christmas (@xmas92 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27019/head:pull/27019
$ git checkout pull/27019

Update a local copy of the PR:
$ git checkout pull/27019
$ git pull https://git.openjdk.org/jdk.git pull/27019/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27019

View PR using the GUI difftool:
$ git pr show -t 27019

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27019.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366476: Test gc/z/TestSmallHeap.java fails OOM with many NUMA nodes

Reviewed-by: jsikstro, aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• af532cc: 8365913: Support latest MSC_VER in abstract_vm_version.cpp
• d19eab4: 8366556: Sort share/runtime includes
• 3fb9246: 8366544: Parallel: Inline PSParallelCompact::invoke_no_policy
• ... and 31 more: https://git.openjdk.org/jdk/compare/f23c150709fbd6d9b84261a7c99b67d7d08334b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0be01611)
• 00: Full (79333670)

[sendaoYan]

/issue JDK-8366476

[openjdk]

@sendaoYan This issue is referenced in the PR title - it will now be updated.

[jsikstro]

Thank you for this! I think this is a good compromise.

With JDK-8359683, the heap memory overhead now scales with the number of NUMA nodes, which means small heaps now play less nice on a machine with many NUMA nodes.

[xmas92]

lgtm.