8354871: Replace stack map frame type magics with constants

[fandreuz]

In this PR I introduce some constants in StackMapGenerator. No change in logic is expected.

Passes tests in jdk/classfile.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354871: Replace stack map frame type magics with constants (Enhancement - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27029/head:pull/27029
$ git checkout pull/27029

Update a local copy of the PR:
$ git checkout pull/27029
$ git pull https://git.openjdk.org/jdk.git pull/27029/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27029

View PR using the GUI difftool:
$ git pr show -t 27029

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27029.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354871: Replace stack map frame type magics with constants

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 93 new commits pushed to the master branch:

• e8c7d2a: 8332872: SetupExecute should cd to temp directory
• dbf4fff: 8366477: Refactor AOT-related flag bits in klass.hpp
• cdc8b5e: 8366455: Move VarHandles.GuardMethodGenerator to execute on build
• ... and 90 more: https://git.openjdk.org/jdk/compare/48f70d7ad85dde49cc8134d4ac0312978a5cc9f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@liach) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fandreuz The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (0c6c04b7)
• 01: Full - Incremental (4a9bf431)
• 00: Full (0ca1e717)

[fandreuz]

Hi @liach, could you have a look at this PR?

[liach]

Can you add a comment on these constants that they are inclusive on both ends? A lot of ranges in Java are open on their higher end, like range notations in Arrays.copyOf or String.substring.

[fandreuz]

Sure: 0c6c04b

[liach]

Thanks for pinging me. This must have got forgotten in the stream of emails.

[liach]

Reviewer's note: This brings more parity with c++ verifier code as done in JDK-8359920 (28e96e3)

[fandreuz]

Thanks for the review @liach

[fandreuz]

/integrate

[openjdk]

@fandreuz
Your change (at version 0c6c04b) is now ready to be sponsored by a Committer.

[liach]

I will wait for the CI results before integration.

[liach]

Tier 1-3 looks good.

/sponsor

[openjdk]

Going to push as commit 8a6b875.
Since your change was applied there have been 95 commits pushed to the master branch:

• 14a40fd: 8361533: Apply java.io.Serial annotations in java.logging
• 6bb15a5: 8367035: [BACKOUT] Protect ExecuteWithLog from running with redirection without a subshell
• e8c7d2a: 8332872: SetupExecute should cd to temp directory
• ... and 92 more: https://git.openjdk.org/jdk/compare/48f70d7ad85dde49cc8134d4ac0312978a5cc9f7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach @fandreuz Pushed as commit 8a6b875.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.