8366543: Clean up include headers in numberSeq

[albertnetymk]

Trivial changing to use the correct includes in numberSeq.hpp/cpp.

Test: tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366543: Clean up include headers in numberSeq (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27031/head:pull/27031
$ git checkout pull/27031

Update a local copy of the PR:
$ git checkout pull/27031
$ git pull https://git.openjdk.org/jdk.git pull/27031/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27031

View PR using the GUI difftool:
$ git pr show -t 27031

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27031.diff

Using Webrev

Link to Webrev Comment

[albertnetymk]

/cc hotspot-gc

[bridgekeeper]

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366543: Clean up include headers in numberSeq

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

• 7c70e73: 8366660: Sort share/nmt includes
• 8c4090c: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F
• e268563: 8366476: Test gc/z/TestSmallHeap.java fails OOM with many NUMA nodes
• ... and 27 more: https://git.openjdk.org/jdk/compare/98af18921aa3c274ef7ece03005337b58df3da96...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@albertnetymk
The hotspot-gc label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (792f98e3)
• 00: Full (d45e5471)

[tschatzl]

CHeapObj is from allocation.hpp. So the original include is correct.

Instead of including the other header just for outputStream, better forward-declare it in the .hpp file here and include it in the cpp file.

[tschatzl]

My rule is if there is a .inline.hpp file, always include it instead of the .hpp file in the .cpp to be sure to catch everything (the inline.hpp always includes the .hpp); and the allocation.hpp must already be included in numberSeq.hpp.

This just gives headaches imo when more code is moved to the .inline.hpp file. It works this time because nothing from CHeapObj is in the inline.hpp file, so technically the removal of this include entirely works (as mentioned in the other comment, numberSeq.hpp needs to include allocation.hpp).

[albertnetymk]

Thanks for review.

/integrate

[openjdk]

Going to push as commit 6dda2f6.
Since your change was applied there have been 30 commits pushed to the master branch:

• 7c70e73: 8366660: Sort share/nmt includes
• 8c4090c: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F
• e268563: 8366476: Test gc/z/TestSmallHeap.java fails OOM with many NUMA nodes
• ... and 27 more: https://git.openjdk.org/jdk/compare/98af18921aa3c274ef7ece03005337b58df3da96...master

Your commit was automatically rebased without conflicts.

[openjdk]

@albertnetymk Pushed as commit 6dda2f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.