Skip to content

Conversation

fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Sep 2, 2025

Sort include statements in hotspot/share/nmt using SortIncludes.java. I'm also removing a couple unnecessary includes.

Passes tier1.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366660: Sort share/nmt includes (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27042/head:pull/27042
$ git checkout pull/27042

Update a local copy of the PR:
$ git checkout pull/27042
$ git pull https://git.openjdk.org/jdk.git pull/27042/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27042

View PR using the GUI difftool:
$ git pr show -t 27042

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27042.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2025

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@fandreuz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366660: Sort share/nmt includes

Reviewed-by: ayang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@fandreuz The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime [email protected] rfr Pull request is ready for review labels Sep 2, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 2, 2025
Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks.

@fandreuz
Copy link
Contributor Author

fandreuz commented Sep 2, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 2, 2025
@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@fandreuz
Your change (at version ab22f2c) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Sep 2, 2025

Yeah, wait 24 hours. This is borderline trivial, but there is no need to rush.

@shipilev
Copy link
Member

shipilev commented Sep 3, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 3, 2025

Going to push as commit 7c70e73.
Since your change was applied there have been 18 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 3, 2025
@openjdk openjdk bot closed this Sep 3, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 3, 2025
@openjdk
Copy link

openjdk bot commented Sep 3, 2025

@shipilev @fandreuz Pushed as commit 7c70e73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants