8366854: Extend jtreg failure handler with THP info #27086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back stefank! A progress list of the required criteria for merging this PR into |
|
@stefank This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 28 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
openjdk
bot
added
core-libs
|
/label add hotspot |
|
@stefank |
|
The proposed changes give the following output the environment.html file: |
Webrevs
|
kstefanj
approved these changes
Sep 4, 2025
| memory.proc_vmstat.args=-c\0cat /proc/vmstat | ||
| memory.proc_vmstat.delimiter=\0 | ||
| memory.thp.app=bash | ||
| memory.thp.args=-c\0cat /sys/kernel/mm/transparent_hugepage/{enabled,defrag} |
There was a problem hiding this comment.
I think we should include shmem_enabled and we could use tail if we want to see what files have what info. But I don't have a strong feeling about that:
$ cat /sys/kernel/mm/transparent_hugepage/{enabled,defrag,shmem_enabled}
always [madvise] never
always defer defer+madvise [madvise] never
always within_size advise [never] deny force
Versus:
$ tail /sys/kernel/mm/transparent_hugepage/{enabled,defrag,shmem_enabled}
==> /sys/kernel/mm/transparent_hugepage/enabled <==
always [madvise] never
==> /sys/kernel/mm/transparent_hugepage/defrag <==
always defer defer+madvise [madvise] never
==> /sys/kernel/mm/transparent_hugepage/shmem_enabled <==
always within_size advise [never] deny force
There was a problem hiding this comment.
I added shmem_enabled but kept cat for now.
albertnetymk
approved these changes
Sep 4, 2025
shipilev
approved these changes
Sep 4, 2025
tschatzl
approved these changes
Sep 5, 2025
lmesnik
approved these changes
Sep 5, 2025
|
Thanks for the reviews! |
|
Going to push as commit a1ab12b.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose that we also dump /proc/meminfo, /proc/vmstat, and /sys/kernel/mm/transparent_hugepage/{enabled, defrag} from the failure handler.
This information has been helpful when investigating a failure where there was an unexpected lack of transparent huge pages.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27086/head:pull/27086$ git checkout pull/27086Update a local copy of the PR:
$ git checkout pull/27086$ git pull https://git.openjdk.org/jdk.git pull/27086/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27086View PR using the GUI difftool:
$ git pr show -t 27086Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27086.diff
Using Webrev
Link to Webrev Comment