-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8366149: JNI exception pending in Java_sun_awt_X11GraphicsDevice_pGetBounds of awt_GraphicsEnv.c:1484 #27110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DamonGuy
wants to merge
13
commits into
openjdk:master
Choose a base branch
from
DamonGuy:8366149/awtGetBounds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Welcome back dnguyen! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
prrace
reviewed
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scenario where AWT's UNLOCK API encounters a pendingException, the env pointer throws the pendingException (as seen in
awt.h
). However, inJava_sun_awt_X11GraphicsDevice_pGetBounds
, afterAWT_UNLOCK
, the bounds var is set. The exception check does not occur until after the bounds is set, so the bounds may be set to an undesired value. This fix adds another exception check to look for this pendingException afterAWT_UNLOCK
.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27110/head:pull/27110
$ git checkout pull/27110
Update a local copy of the PR:
$ git checkout pull/27110
$ git pull https://git.openjdk.org/jdk.git pull/27110/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27110
View PR using the GUI difftool:
$ git pr show -t 27110
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27110.diff
Using Webrev
Link to Webrev Comment