8365192: post_meth_exit should be in vm state when calling get_jvmti_thread_state #27112
+46
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second attempt to fix method
post_meth_exit
to correctly set state and preserve result.The related fix here:
b7b64bb
Hope fix became clarere now.
There 2 problems in this post_meth_exit:
state->is_enabled(JVMTI_EVENT_METHOD_EXIT)
however transition in the JRT_BLOCK_END happens always. So there is a risk of loosing method results in the interp_only mode.get_jvmti_thread_state
should be called when thread is in vm state only.The fix adds
post_method_exit_transition
to have single exit point with oop restoration.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27112/head:pull/27112
$ git checkout pull/27112
Update a local copy of the PR:
$ git checkout pull/27112
$ git pull https://git.openjdk.org/jdk.git pull/27112/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27112
View PR using the GUI difftool:
$ git pr show -t 27112
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27112.diff
Using Webrev
Link to Webrev Comment