Skip to content

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Sep 5, 2025

This is the second attempt to fix method post_meth_exit to correctly set state and preserve result.
The related fix here:
b7b64bb
Hope fix became clarere now.

There 2 problems in this post_meth_exit:

  1. The result is preserved only if state->is_enabled(JVMTI_EVENT_METHOD_EXIT) however transition in the JRT_BLOCK_END happens always. So there is a risk of loosing method results in the interp_only mode.
  2. The method get_jvmti_thread_state should be called when thread is in vm state only.

The fix adds post_method_exit_transition to have single exit point with oop restoration.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8365192: post_meth_exit should be in vm state when calling get_jvmti_thread_state (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27112/head:pull/27112
$ git checkout pull/27112

Update a local copy of the PR:
$ git checkout pull/27112
$ git pull https://git.openjdk.org/jdk.git pull/27112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27112

View PR using the GUI difftool:
$ git pr show -t 27112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27112.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 5, 2025

@lmesnik The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Sep 5, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant