8365630: jdk/jfr/tool/TestPrintContextual.java fails with wrong spanId

[egahlin]

Could I get a review of a test fix that emits events with unique timestamps, so the contextual information is printed in chronological order?

Testing: 500 * jdk/jfr/tool/TestPrintContextual.java

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8365630: jdk/jfr/tool/TestPrintContextual.java fails with wrong spanId (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27626/head:pull/27626
$ git checkout pull/27626

Update a local copy of the PR:
$ git checkout pull/27626
$ git pull https://git.openjdk.org/jdk.git pull/27626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27626

View PR using the GUI difftool:
$ git pr show -t 27626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27626.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8365630: jdk/jfr/tool/TestPrintContextual.java fails with wrong spanId

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• 2bfada3: 8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java
• 2c114d6: 8367899: compiler/c2/gvn/TestBitCompressValueTransform.java intermittent timed out
• baf8bc5: 8369038: Parallel: Use NMethodMarkingScope and ThreadsClaimTokenScope in psParallelCompact
• ... and 17 more: https://git.openjdk.org/jdk/compare/72319167543a28295276f11178c17bef6680c32f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (d433a73d)
• 00: Full (27d913c5)

[shipilev]

Why ignore, though? This would make the thread stuck even if someone actively tries to interrupt it. A common practice in these non-critical methods is to restore the interrupt status and return.

} catch (InterruptedException e) {
    Thread.currentThread().interrupt();
    return;
}

[egahlin]

The purpose is to save CPU cycles instead of spinning. I'm not sure how returning would help? The test would become unreliable, since two timestamps may be the same.

I could let the method throw an InterruptedException so the test fails, but it would result in a false positive. Perhaps, if jtreg for some reason wanted to shut down the test early, it could serve a purpose.

[shipilev]

This looks better, thanks!

[egahlin]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 2376a9e.
Since your change was applied there have been 24 commits pushed to the master branch:

• 0f406c4: 8369078: Fix faulty test conversion in IllegalCharsetName.java
• 596af0a: 8369041: Release memory after testing in ThreadsRunner.java
• b6a4cfe: 8367114: Update jdk.test.lib.net.SimpleHttpServer to use SimpleFileServer
• ... and 21 more: https://git.openjdk.org/jdk/compare/72319167543a28295276f11178c17bef6680c32f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 2376a9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.