Skip to content

Conversation

@PeyaPeyaPeyang
Copy link
Contributor

@PeyaPeyaPeyang PeyaPeyaPeyang commented Nov 2, 2025

Removed comment about Windows 95 runtime linking, since Windows 95 is no longer supported:

Some early versions of Windows 95 do not support the required functions.
Use runtime linking to avoid problems.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366058: Outdated comment in WinCAPISeedGenerator (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28105/head:pull/28105
$ git checkout pull/28105

Update a local copy of the PR:
$ git checkout pull/28105
$ git pull https://git.openjdk.org/jdk.git pull/28105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28105

View PR using the GUI difftool:
$ git pr show -t 28105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28105.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2025

👋 Welcome back PeyaPeyaPeyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 2, 2025

@PeyaPeyaPeyang The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 2, 2025

Webrevs

@AlanBateman
Copy link
Contributor

/label remove core-libs
/label add security

@openjdk
Copy link

openjdk bot commented Nov 2, 2025

@AlanBateman
The core-libs label was successfully removed.

@openjdk openjdk bot added security [email protected] and removed rfr Pull request is ready for review labels Nov 2, 2025
@openjdk
Copy link

openjdk bot commented Nov 2, 2025

@AlanBateman
The security label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review security [email protected]

Development

Successfully merging this pull request may close these issues.

2 participants