-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add jfr event for dns lookup #28110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add jfr event for dns lookup #28110
Conversation
Signed-off-by: NeatGuyCoding <[email protected]>
|
👋 Welcome back NeatGuyCoding! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@NeatGuyCoding The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
It might be useful to differentiate between three use cases:
It might also be useful to include some information about the DNS cache itself — for example, whether the result came from cache, the TTL of the entry, or whether stale data was used. What do you think? |
Thanks for the reply, I will investigate and make some updates |
Signed-off-by: NeatGuyCoding <[email protected]>
|
@mrserb redesigned, kindly check, thanks |
|
Please start a discussion on net-dev. Also keep in mind that these methods use whatever name service is configured so the lookups may not be DNS. This will influence the naming, if events are introduced. |
|
email sent to [email protected] |
Necessity of Adding DNS Lookup JFR Event
Cloud-native environments rely heavily on DNS for service discovery, where DNS queries are frequent and latency-critical. Java's DNS caching policy (default 30s TTL) significantly impacts performance.
Problems:
Value:
This event complements
SocketRead/Writeevents, enhancing network observability.Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28110/head:pull/28110$ git checkout pull/28110Update a local copy of the PR:
$ git checkout pull/28110$ git pull https://git.openjdk.org/jdk.git pull/28110/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28110View PR using the GUI difftool:
$ git pr show -t 28110Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28110.diff