Skip to content

8352677: Opensource JMenu tests - series2 #3850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

satyenme
Copy link

@satyenme satyenme commented Aug 13, 2025

Backporting JDK-8352677: Opensource JMenu tests - series2. Adds three javax/swing tests, testing which menus are focused/displayed when submenus are opened and closed. Ran GHA Sanity Checks, local Tier 1 and 2, and new tests directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352677 needs maintainer approval

Issue

  • JDK-8352677: Opensource JMenu tests - series2 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3850/head:pull/3850
$ git checkout pull/3850

Update a local copy of the PR:
$ git checkout pull/3850
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3850

View PR using the GUI difftool:
$ git pr show -t 3850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3850.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352677: Opensource JMenu tests - series2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport cfc648bd17cc79b1c3e6f69d3559749e937261b2 8352677: Opensource JMenu tests - series2 Aug 13, 2025
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 13, 2025
@openjdk
Copy link

openjdk bot commented Aug 13, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 13, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8352677: Opensource JMenu tests - series2

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2 and new manual tests. Patch is clean. Although change has only been present in tip since March, 2025, change has been accepted by Oracle (and tests were previously closed source).

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

@satyenme
8352677: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 13, 2025
@satyenme
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 14, 2025

Going to push as commit 860896a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 4addb57: 8342075: HttpClient: improve HTTP/2 flow control checks

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 14, 2025
@openjdk openjdk bot closed this Aug 14, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 14, 2025
@openjdk
Copy link

openjdk bot commented Aug 14, 2025

@satyenme Pushed as commit 860896a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant