Skip to content

8358004: Delete applications/scimark/Scimark.java test #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 4, 2025

Hi all,

This pull request contains a backport of commit f1f6452e from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 17 Jul 2025 and was reviewed by Coleen Phillimore.

This backport PR is intend to remove the outdated and unmaintained test. Test-fix only, no risk.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358004 needs maintainer approval

Issue

  • JDK-8358004: Delete applications/scimark/Scimark.java test (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2044/head:pull/2044
$ git checkout pull/2044

Update a local copy of the PR:
$ git checkout pull/2044
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2044

View PR using the GUI difftool:
$ git pr show -t 2044

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2044.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@sendaoYan sendaoYan changed the title Backport f1f6452 Backport f1f6452e01e5a4521cb333d7456333f00cd9680c Aug 4, 2025
@openjdk openjdk bot changed the title Backport f1f6452e01e5a4521cb333d7456333f00cd9680c 8358004: Delete applications/scimark/Scimark.java test Aug 4, 2025
@openjdk
Copy link

openjdk bot commented Aug 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 4, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2025

Webrevs

Reviewed-by: coleenp
Backport-of: a5c9bc70324693e9d0b25bb2c51b91dfc750c453
@sendaoYan
Copy link
Member Author

Looking reviewers for remove outdated test.

@openjdk
Copy link

openjdk bot commented Aug 13, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

/approval request Backport to remove the outdated and unmaintained test. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Aug 14, 2025

@sendaoYan
8358004: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants