Skip to content

8361478: GHA: Use MSYS2 from GHA runners #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 15, 2025

Improves GHA performance a bit.

Additional testing:

  • GHA

Progress

  • JDK-8361478 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361478: GHA: Use MSYS2 from GHA runners (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2104/head:pull/2104
$ git checkout pull/2104

Update a local copy of the PR:
$ git checkout pull/2104
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2104

View PR using the GUI difftool:
$ git pr show -t 2104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2104.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ed9066bdf48c2d9925aea745951531ebf4af35a8 8361478: GHA: Use MSYS2 from GHA runners Aug 15, 2025
@openjdk
Copy link

openjdk bot commented Aug 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 15, 2025
@openjdk
Copy link

openjdk bot commented Aug 15, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 15, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2025

Webrevs

@shipilev
Copy link
Member Author

/approval request Improves GHA performance. The patch was in mainline for a few weeks, and we have seen no problems with it. Applies cleanly. Risk is low: GHA only patch.

@openjdk
Copy link

openjdk bot commented Aug 15, 2025

@shipilev
8361478: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 15, 2025
@shipilev
Copy link
Member Author

GHA failure is environmental. I'll restart the jobs just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant