Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 25, 2025

I backport this for parity with 21.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8356023 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8356023: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee: part 2 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2396/head:pull/2396
$ git checkout pull/2396

Update a local copy of the PR:
$ git checkout pull/2396
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2396/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2396

View PR using the GUI difftool:
$ git pr show -t 2396

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2396.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/2395 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356023: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee: part 2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 927309453822183bbfa9af278043fe0dca17031c 8356023: Some nsk/jdi tests can fetch ThreadReference from static field in the debuggee: part 2 Oct 25, 2025
@openjdk
Copy link

openjdk bot commented Oct 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Oct 25, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2025

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 26, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 26, 2025

GHA failure: win build failed, infra issue, unrelated.

IOException caught during compilation: Connection reset
make[3]: *** [test/BuildJtregTestThreadFactory.gmk:41: /d/a/jdk21u-dev/jdk21u-dev/build/windows-x64/support/test/jtreg_test_thread_factory/classes/_the.BUILD_JTREG_TEST_THREAD_FACTORY_batch] Error 1
make[3]: Target 'build' not remade because of errors.
make[2]: *** [make/Main.gmk:752: build-test-test-thread-factory] Error 2

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Oct 28, 2025
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/2395 to master October 28, 2025 09:16
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8356023
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Oct 28, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@GoeLin This pull request has not yet been marked as ready for integration.

@openjdk openjdk bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Oct 28, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

Going to push as commit 5076a6d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2025
@openjdk openjdk bot closed this Oct 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@GoeLin Pushed as commit 5076a6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8356023 branch October 28, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant