Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 27, 2025

I backport this to keep the tests up to date and make later backports clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355569 needs maintainer approval

Issue

  • JDK-8355569: Some nsk/jdi tests can glean the "main" thread by using the ClassPrepareEvent for the debuggee main class (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2406/head:pull/2406
$ git checkout pull/2406

Update a local copy of the PR:
$ git checkout pull/2406
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2406/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2406

View PR using the GUI difftool:
$ git pr show -t 2406

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2406.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/2404 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355569: Some nsk/jdi tests can glean the "main" thread by using the ClassPrepareEvent for the debuggee main class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport e2ae50d877b13b121912e2496af4b5209b315a05 8355569: Some nsk/jdi tests can glean the "main" thread by using the ClassPrepareEvent for the debuggee main class Oct 27, 2025
@openjdk
Copy link

openjdk bot commented Oct 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8355569 branch from c8bcdf2 to 2c5b571 Compare October 27, 2025 14:07
@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Oct 27, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@GoeLin This pull request has not yet been marked as ready for integration.

@GoeLin GoeLin changed the base branch from pr/2404 to master October 28, 2025 09:14
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

Going to push as commit 799b63a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2025
@openjdk openjdk bot closed this Oct 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@GoeLin Pushed as commit 799b63a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8355569 branch October 28, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant