Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Oct 27, 2025

Backporting JDK-8318467: Tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads. Adjusted the capacity of the queues. Ran GHA Sanity Checks (passed) and adjusted tests (passed). Patch is clean.

time java -jar build/*/images/test/micro/benchmarks.jar -f 1 -wi 2 -w 10 -i 2 -r 15 -t 240 -bm thrpt -tu ms -p type=ABQ_F java.util.concurrent.Queues

...
21.67 user
41.30 system
0:50.75 elapsed
...

time java -jar build/*/images/test/micro/benchmarks.jar -f 1 -wi 2 -w 10 -i 2 -r 15 -t 240 -bm thrpt -tu ms -p type=ABQ_F java.util.concurrent.ProducerConsumer

...
105.22 user
270.30 system
5:09.03 elapsed
...


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318467 needs maintainer approval

Issue

  • JDK-8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2408/head:pull/2408
$ git checkout pull/2408

Update a local copy of the PR:
$ git checkout pull/2408
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2408/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2408

View PR using the GUI difftool:
$ git pr show -t 2408

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2408.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 27, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

Hi @rm-gh-8, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rm-gh-8" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport e05cafda78a37dbeb2df2edd791be19d22edaece 8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads Oct 27, 2025
@openjdk
Copy link

openjdk bot commented Oct 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 27, 2025
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Oct 27, 2025

/covered

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Oct 27, 2025

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 27, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@rm-gh-8 rm-gh-8 marked this pull request as ready for review October 28, 2025 16:59
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Oct 28, 2025

/approval request for backport of JDK-8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads

Motivation: This backport adjusts the capacity to allow the proper execution/completion of the tests

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@rm-gh-8
8318467: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Oct 28, 2025
@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Oct 29, 2025
@openjdk
Copy link

openjdk bot commented Oct 29, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2025

Webrevs

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Oct 29, 2025

/approval request for backport of JDK-8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads

Motivation: This backport adjusts the capacity to allow the proper execution/completion of the tests.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@rm-gh-8
8318467: The approval request has been updated successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 29, 2025
@GoeLin
Copy link
Member

GoeLin commented Oct 30, 2025

@rm-gh-8
Please check the GHA failures and note in a comment why you think you can integrate anyways if this is the case.

GHA failure: java/lang/ProcessBuilder/Basic#id0, issue of the test, fixed in meantime, unrelated to this change.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 30, 2025
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Oct 30, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 30, 2025
@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@rm-gh-8
Your change (at version aacb0ce) is now ready to be sponsored by a Committer.

@Rudometov
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 30, 2025

Going to push as commit b17a237.
Since your change was applied there have been 24 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2025
@openjdk openjdk bot closed this Oct 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 30, 2025
@openjdk
Copy link

openjdk bot commented Oct 30, 2025

@Rudometov @rm-gh-8 Pushed as commit b17a237.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants