-
Notifications
You must be signed in to change notification settings - Fork 145
8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads #2408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads #2408
Conversation
|
Hi @rm-gh-8, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user rm-gh-8" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
/covered |
|
/signed |
|
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
/approval request for backport of JDK-8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads Motivation: This backport adjusts the capacity to allow the proper execution/completion of the tests |
|
|
|
/approval request for backport of JDK-8318467: [jmh] tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads Motivation: This backport adjusts the capacity to allow the proper execution/completion of the tests. |
|
@rm-gh-8 GHA failure: java/lang/ProcessBuilder/Basic#id0, issue of the test, fixed in meantime, unrelated to this change. |
|
/integrate |
|
/sponsor |
|
Going to push as commit b17a237.
Your commit was automatically rebased without conflicts. |
|
@Rudometov @rm-gh-8 Pushed as commit b17a237. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting JDK-8318467: Tests concurrent.Queues and concurrent.ProducerConsumer hang with 101+ threads. Adjusted the capacity of the queues. Ran GHA Sanity Checks (passed) and adjusted tests (passed). Patch is clean.
time java -jar build/*/images/test/micro/benchmarks.jar -f 1 -wi 2 -w 10 -i 2 -r 15 -t 240 -bm thrpt -tu ms -p type=ABQ_F java.util.concurrent.Queues
...
21.67 user
41.30 system
0:50.75 elapsed
...
time java -jar build/*/images/test/micro/benchmarks.jar -f 1 -wi 2 -w 10 -i 2 -r 15 -t 240 -bm thrpt -tu ms -p type=ABQ_F java.util.concurrent.ProducerConsumer
...
105.22 user
270.30 system
5:09.03 elapsed
...
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2408/head:pull/2408$ git checkout pull/2408Update a local copy of the PR:
$ git checkout pull/2408$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2408/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2408View PR using the GUI difftool:
$ git pr show -t 2408Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2408.diff
Using Webrev
Link to Webrev Comment