Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Oct 28, 2025

Backporting JDK-8354465: Open some JTable bugs 8. Adds five JTable test. Ran GHA Sanity Checks and new tests directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8354465 needs maintainer approval

Issue

  • JDK-8354465: Open some JTable bugs 8 (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2410/head:pull/2410
$ git checkout pull/2410

Update a local copy of the PR:
$ git checkout pull/2410
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2410/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2410

View PR using the GUI difftool:
$ git pr show -t 2410

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2410.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7a72f0fac9a0704c4a0ada781f1cadd7c4903b3e 8354465: Open some JTable bugs 8 Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8354465: Open some JTable bugs 8

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks and new manual tests. Patch is clean. Although change has only been present in tip since April, 2025, change has been accepted by Oracle (and tests were previously closed source).

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@satyenme
8354465: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant