Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 31, 2025

Hi all,

This pull request contains a backport of commit 89c5659a from the openjdk/jdk25u repository.

The commit being backported was authored by SendaoYan on 31 Oct 2025 and was reviewed by Paul Hohensee.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8366850 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8366694 needs maintainer approval

Issues

  • JDK-8366694: Test JdbStopInNotificationThreadTest.java timed out after 60 second (Bug - P4)
  • JDK-8366850: Test com/sun/jdi/JdbStopInNotificationThreadTest.java failed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2436/head:pull/2436
$ git checkout pull/2436

Update a local copy of the PR:
$ git checkout pull/2436
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2436

View PR using the GUI difftool:
$ git pr show -t 2436

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2436.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 89c5659aa88acd1e9624aa14e5b9757255e55916 8366694: Test JdbStopInNotificationThreadTest.java timed out after 60 second Oct 31, 2025
@openjdk
Copy link

openjdk bot commented Oct 31, 2025

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 31, 2025
@openjdk
Copy link

openjdk bot commented Oct 31, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant