8341443: [macos] AppContentTest and SigningOptionsTest failed due to "codesign" does not fails with "--app-content" on macOS 15 #2442
+14
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I backport this to simplify backporting "8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions" which reworks this test fix.
Omitted SigningOptionsTest.java which was added by 8311877: [macos] Add CLI options to provide signing identity directly to codesign and productbuild in 22.
Omitted adding @modules to AppContentTest as later change "8343314: Move common properties from jpackage jtreg test declarations to TEST.properties file" was already backported in 21.0.7.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2442/head:pull/2442$ git checkout pull/2442Update a local copy of the PR:
$ git checkout pull/2442$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2442/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2442View PR using the GUI difftool:
$ git pr show -t 2442Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2442.diff
Using Webrev
Link to Webrev Comment