Skip to content

Conversation

@snazarkin
Copy link

@snazarkin snazarkin commented Nov 5, 2025

Hi all,

This pull request contains a backport of commit 4520983e from the openjdk/jdk repository.

The commit being backported was authored by Sergey Nazarkin on 3 Nov 2025 and was reviewed by Sergey Bylokhov, Phil Race and Prasanta Sadhukhan.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8368882 needs maintainer approval

Issue

  • JDK-8368882: NPE during text drawing on machine with JP locale (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2448/head:pull/2448
$ git checkout pull/2448

Update a local copy of the PR:
$ git checkout pull/2448
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2448

View PR using the GUI difftool:
$ git pr show -t 2448

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2448.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2025

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4520983e8e5fcfb22e04508d50676df6831fa636 8368882: NPE during text drawing on machine with JP locale Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

⚠️ @snazarkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 5, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@snazarkin
Copy link
Author

/approval request Fix the bug in the edge case of font rendering code. Tested with reproducer from the bug report.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@snazarkin
8368882: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 5, 2025
@GoeLin
Copy link
Member

GoeLin commented Nov 6, 2025

Hi @snazarkin
please first backport to 25. If that is approved, you may label again.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants