Skip to content

Conversation

aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Sep 8, 2025

Updated some versions in codebase that were referring to 9.1.0 toward 10.0.0


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8438: Update the version of JMC to 10.0.0 (Task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/673/head:pull/673
$ git checkout pull/673

Update a local copy of the PR:
$ git checkout pull/673
$ git pull https://git.openjdk.org/jmc.git pull/673/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 673

View PR using the GUI difftool:
$ git pr show -t 673

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/673.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 8, 2025

👋 Welcome back aymane-harmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 8, 2025

@aymane-harmaz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8438: Update the version of JMC to 10.0.0

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Sep 8, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 8, 2025

Webrevs

@openjdk openjdk bot added the ready label Sep 10, 2025
@aymane-harmaz
Copy link
Member Author

Thanks for the review

/integrate

@openjdk openjdk bot added the sponsor label Sep 11, 2025
@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@aymane-harmaz
Your change (at version f9f69f9) is now ready to be sponsored by a Committer.

@Suchitainf
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

Going to push as commit 84b5127.

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@Suchitainf @aymane-harmaz Pushed as commit 84b5127.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants