Skip to content

Upload v2 Secure Releases Guide Markdown #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruddermann
Copy link
Collaborator


**DO NOT**

* Transfer access tokens using end-to-end encrypted (E2EE) channels like email, Slack, and Teams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"like email, Slack, and Teams" and "like Signal and Whatsapp" aren't meaningfully different to me, and don't give me any info how to figure out whether a service is in the "do" or "do not" category, nor why these are in these categories.

are perhaps these meant to be "non-E2EE"?


* Transfer access tokens using end-to-end encrypted (E2EE) channels like email, Slack, and Teams
* Copy access tokens or recovery codes into your clipboard (especially on Linux and Windows)
* Print out access tokens or recovery codes using a that does not belong to you (such as a work printer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Print out access tokens or recovery codes using a that does not belong to you (such as a work printer)
* Print out access tokens or recovery codes using a printer that does not belong to you (such as a work printer)


*Safe Storage and Use of Access Tokens*

The npm CLI uses the .npmrc file for configuration. Included in this file is the _AuthToken variable, which npm uses to authenticate to the public registry or a private registry. Npm’s decision to store access tokens in a plain text file is inherently unsafe and additional measures must be taken to properly use and store it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The npm CLI uses the .npmrc file for configuration. Included in this file is the _AuthToken variable, which npm uses to authenticate to the public registry or a private registry. Npm’s decision to store access tokens in a plain text file is inherently unsafe and additional measures must be taken to properly use and store it.
The npm CLI uses the .npmrc file for configuration. Included in this file is the _AuthToken variable, which npm uses to authenticate to the public registry or a private registry. npm’s decision to store access tokens in a plain text file is inherently unsafe and additional measures must be taken to properly use and store it.

Comment on lines +322 to +324
This scenario has many potential approaches. First, use the correct access token for the job:

* GATs should never be stored on a local hard drive (eg: in an .npmrc file)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm confused; afaik this is the only way to store it.

* Is automatically granted read/write permissions for new packages added to the organization.
* Cannot be removed from organization packages.

Given these behaviors, it’s recommended to not use the developers team when granting users write access to packages. Instead, set its access to read for each existing package in the organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of "set its access to read", i'd suggest making a different team for each package, adding the package to that team, and then removing the package from the developers team. (the order matters) ie, your next section

meaning, the developers team should have zero packages on it at all.

notably, there is no "read" and "write" - either you have full 100% owner access on a package, or you have zero access to a package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants