Update spotless to 7.1.0

[Pankraz76]

Update spotless to 7.1.0

[Describe what this change achieves]

while experimenting with rewrite i came across this custom solution for what recently has been integrated into spot.

• activate removeWildcardImports() diffplug/spotless#2526
• removeUnusedPrivateMethods Pankraz76/OpenSearch#2

could not do it without @iddeepak, thanks for the decent impl.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 2ea7836: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[owaiskazi19]

Looks like the support was added recently diffplug/spotless#2517, we relied on the custom logic until now

[owaiskazi19]

Thanks @Pankraz76 for the change!

[Pankraz76]

Thanks @Pankraz76 for the change!

could not do it without @iddeepak, thanks for the decent impl.

[Pankraz76]

Looks like the support was added recently diffplug/spotless#2517, we relied on the custom logic until now

kindly FYI: its been around, so might be any good, despite the academical risk. @sbrannen

[owaiskazi19]

@Pankraz76 I tested this on local, with this plugin it removes the wildcard imports directly and doesn't add associated imports. After running spotlessApply imports are removed, it causes compile issues.
Whereas the current implementation calls out the file where wildcard import was used

Step 'Refuse wildcard imports' found problem in 'src/test/java/org/opensearch/neuralsearch/processor/normalization/ZScoreNormalizationTechniqueTests.java':
Do not use wildcard imports.  'spotlessApply' cannot resolve this issue.
java.lang.AssertionError: Do not use wildcard imports.  'spotlessApply' cannot resolve this issue.
        at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
        at formatting_a046l3dushzjseo478wpr27to$_run_closure1$_closure2$_closure3$_closure6.doCall$original(/Users/kazabdu/Documents/neural-search/gradle/formatting.gradle:17)
        at formatting_a046l3dushzjseo478wpr27to$_run_closure1$_closure2$_closure3$_closure6.doCall(/Users/kazabdu/Documents/neural-search/gradle/formatting.gradle)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)

[Pankraz76]

yes its just able to remove not replace unfortunately. Assuming its just a simple regex as before its not the workaround solution provided by issue discussion, moved into dedicated rule.

[Pankraz76]

yes its just able to remove not replace unfortunately. Assuming its just a simple regex as before its not the workaround solution provided by issue discussion, moved into dedicated rule.

its assuming that removal of the code is not compiling anymore therefore unable to ship.

The local changes can then be resolved by some IDE just opening the changed files.

As spot has no type awareness its not able to really replace the wildcard like desired and expected as spot normally delivers the fixes.

Rewrite can deliver this.

But we can and should adapt to fail the build and not break the code. This is kind of awkward. Just throwing the error as before on wildcard detected would be more complain, with very good reasoning given by @sbrannen

[github-actions]

❌ Gradle check result for bd777ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for bd777ca: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[iddeepak]

I agree with the proposal that failing the build with a clear lint error is safer and more predictable than silently removing critical imports. Thank you @Pankraz76, Learning as always from your contributions!

[owaiskazi19]

@Pankraz76 should we wait for diffplug/spotless#2557 to released with the new version and then we can make the changes to use removeWildcardImports?

[Pankraz76]

sure thing no need to rush.

Actually should just dedicate the feature in PR. Is does not change anything, as it seems here are not wildcards.
Having one thing only, is always nice approach. Thanks for suggestion.

[github-actions]

❌ Gradle check result for f95f1d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?