-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Ignore attribute awareness when custom preference is set #18848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore attribute awareness when custom preference is set #18848
Conversation
❌ Gradle check result for 7b2b6f9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky - #18850 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18848 +/- ##
============================================
+ Coverage 72.67% 72.78% +0.10%
- Complexity 68610 68612 +2
============================================
Files 5577 5577
Lines 315375 315374 -1
Branches 45772 45773 +1
============================================
+ Hits 229209 229539 +330
+ Misses 67613 67154 -459
- Partials 18553 18681 +128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
server/src/internalClusterTest/java/org/opensearch/cluster/routing/WeightedRoutingIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
7b2b6f9
to
eabfc36
Compare
❌ Gradle check result for eabfc36: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for eabfc36: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Flaky test #18872 |
❌ Gradle check result for eabfc36: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Same flaky test #18872. |
…project#18848) Signed-off-by: Finn Carroll <[email protected]> Signed-off-by: sunqijun.jun <[email protected]>
…project#18848) Signed-off-by: Finn Carroll <[email protected]>
…project#18848) Signed-off-by: Finn Carroll <[email protected]>
Description
This change addresses a bug which appears when a custom preference string is included with a query while awareness attributes are present on the cluster.
In this scenario it can seem as if the custom preference string included with query is not being honored. This is due to how awareness attributes preference shards which share an attribute with the coordinating node when routing a search request. Awareness attributes take priority and the custom string preference is only applied after this step. A search request with the same custom string preference can then be routed differently depending on which node is acting as coordinator.
All other preference types exit early and ignore awareness attributes with custom string preference being the one exception that attempts to deterministically route requests within awareness attribute groups.
This change ignores awareness attributes when a custom string preference is present.
Related Issues
Resolves #18817
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.