[BUG FIX] Segment Replication cleanup completedReplications when SegmentReplicator.cancel is invoked #18856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guojialiang92
changed the title
|
❌ Gradle check result for 7a85d3c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
guojialiang92
force-pushed
the
dev/clean-completedReplications-when-segmentReplicator-cancel-invoked
branch
from
7a85d3c to
bc9c780
Compare
guojialiang92
force-pushed
the
dev/clean-completedReplications-when-segmentReplicator-cancel-invoked
branch
from
bc9c780 to
4ea54d1
Compare
|
❌ Gradle check result for 4ea54d1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
guojialiang92
force-pushed
the
dev/clean-completedReplications-when-segmentReplicator-cancel-invoked
branch
from
4ea54d1 to
51d3048
Compare
Signed-off-by: guojialiang <[email protected]>
guojialiang92
force-pushed
the
dev/clean-completedReplications-when-segmentReplicator-cancel-invoked
branch
from
51d3048 to
47943ad
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18856 +/- ##
============================================
- Coverage 72.79% 72.78% -0.01%
+ Complexity 68627 68596 -31
============================================
Files 5572 5577 +5
Lines 315196 315376 +180
Branches 45750 45772 +22
============================================
+ Hits 229454 229554 +100
- Misses 67153 67213 +60
- Partials 18589 18609 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, @mch2 @ashking94. |
|
This PR is stalled because it has been open for 30 days with no activity. |
opensearch-trigger-bot
bot
added
stalled
mch2
approved these changes
Sep 16, 2025
|
sorry for the delay here, thanks for the cleanup @guojialiang92 |
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…ed (opensearch-project#18856) Signed-off-by: guojialiang <[email protected]>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…ed (opensearch-project#18856) Signed-off-by: guojialiang <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
…ed (opensearch-project#18856) Signed-off-by: guojialiang <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
asimmahmood1
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 23, 2025
…ed (opensearch-project#18856) Signed-off-by: guojialiang <[email protected]>
pranikum
pushed a commit
to pranikum/OpenSearch
that referenced
this pull request
Sep 23, 2025
…ed (opensearch-project#18856) Signed-off-by: guojialiang <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…ed (opensearch-project#18856) Signed-off-by: guojialiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found that
SegmentReplicator#completedReplicationsonly has addition logic but no cleanup logic.We should clean up
SegmentReplicator#completedReplicationswhenSegmentReplicator#cancelis invoked. Otherwise, it may cause a risk of memory leak.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.